Skip to content

sieve-editor-gui: add darwin support, 0.6.1-unstable-{2024-01-06 -> 2025-03-12}#426349

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
fugidev:sieve-darwin
Sep 1, 2025
Merged

sieve-editor-gui: add darwin support, 0.6.1-unstable-{2024-01-06 -> 2025-03-12}#426349
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
fugidev:sieve-darwin

Conversation

@fugidev
Copy link
Member

@fugidev fugidev commented Jul 18, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and others READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 18, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 18, 2025
@nix-owners nix-owners bot requested a review from Silver-Golden July 18, 2025 11:41
@fugidev fugidev force-pushed the sieve-darwin branch 2 times, most recently from 2ba3f5e to 6944ece Compare July 18, 2025 12:29
@ofalvai
Copy link
Contributor

ofalvai commented Jul 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 426349
Commit: 6944ecec645f38a7b125af0afa6366b1607bfe5c

aarch64-linux

✅ 1 package built:
  • sieve-editor-gui

x86_64-darwin

✅ 1 package built:
  • sieve-editor-gui

aarch64-darwin

✅ 1 package built:
  • sieve-editor-gui

ofalvai
ofalvai approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@ofalvai ofalvai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on macOS

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 23, 2025
@nixos-discourse
Copy link

nixos-discourse commented Aug 1, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2492

@fugidev
Copy link
Member Author

fugidev commented Aug 15, 2025

Pinging again @Silver-Golden, your review as package maintainer would be highly appreciated :)

SuperSandro2000
SuperSandro2000 reviewed Aug 31, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 1, 2025
@SuperSandroBot
Copy link

SuperSandroBot commented Sep 1, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 426349
Commit: 44cd52cc31441c7f1417607c033bc7bfd68c65af (subsequent changes)
Merge: 0d762ee14750dd830ca0f2af3b7f3173cae583c4

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/17381084295

x86_64-linux

✅ 1 package built:
  • sieve-editor-gui

aarch64-linux

✅ 1 package built:
  • sieve-editor-gui

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • sieve-editor-gui

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • sieve-editor-gui

@SuperSandro2000 SuperSandro2000 merged commit 86d6dc4 into NixOS:master Sep 1, 2025
30 of 32 checks passed
@fugidev
Copy link
Member Author

fugidev commented Sep 1, 2025

Thanks for reviewing and merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Silver-Golden Silver-Golden Awaiting requested review from Silver-Golden

+1 more reviewer

@ofalvai ofalvai ofalvai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fugidev @ofalvai @nixos-discourse @SuperSandroBot @SuperSandro2000